feat: Add the compiled bundle to npm. #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thet
force-pushed
the
add-dist
branch
4 times, most recently
from
6ade9af to
b09bf1e
Compare
jensens
reviewed
Nov 14, 2022
Creating a npm release with the Makefile prepares now a bundle build with the correct package version added as a comment to the bundle files. The compiled bundle can then be uploaded to npm if it is part of the git repository (included by .gitignore) or part of the npm release (preferred, included by .npmignore). Adding the compiled bundle to npm allows to directly include it via a CDN like so: https://cdn.jsdelivr.net/npm/@patternslib/patternslib@9.7.0-alpha.2/dist/bundle.min.js or https://unpkg.com/@patternslib/patternslib@9.7.0-alpha.2/dist/bundle.min.js We have to compile the bundle with the correct version BEFORE the npm package is created with release-it. The next version is queried using the LEVEL parameter (set by the different release targets) and the "semver" tool.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a non breaking change.
Adding the compiled bundle to npm allows to directly include it via a
CDN like so:
https://cdn.jsdelivr.net/npm/@patternslib/patternslib@9.7.0-alpha.2/dist/bundle.min.js
or
https://unpkg.com/@patternslib/patternslib@9.7.0-alpha.2/dist/bundle.min.js
We have to compile the bundle with the correct version BEFORE the npm
package is created with release-it. The next version is queried using
the LEVEL parameter (set by the different release targets) and the
"semver" tool.